Ia proposals #1
Closed
Ia proposals #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 13 new granular outputs for repository basic attributes - Add security_configuration output with all security features - Add merge_configuration output with all merge settings - Add features_enabled output with repository features - Add environments, webhooks, rulesets outputs from submodules - Add deploy_keys and auto_generated_deploy_keys outputs - Maintain backwards compatibility with original outputs - Update module documentation with terraform-docs This implements improvement 1.1 from IMPROVEMENT_PROPOSALS.md Elevates module from 8.2/10 towards 9.5/10 premium status
…h output Replace deprecated github_repository.this.default_branch attribute with github_branch_default.this[0].branch to eliminate deprecation warnings. This fixes the warning: 'The attribute "default_branch" is deprecated. Refer to the provider documentation for details.' ✅ All tests still passing: 79/79 with zero warnings
- Add OUTPUTS_MIGRATION_GUIDE.md with examples for migrating to granular outputs - Update IMPROVEMENT_PROPOSALS.md checklist marking task 1.1 as completed - Include before/after examples and best practices This completes the documentation for improvement 1.1
- Split complex 'repositories' local into 4 helper locals for better readability - _repos_base_config: handles coalesce logic (repository > settings > defaults) - _repos_merge_config: handles map merging (settings + repository overrides) - _repos_union_config: handles list unions (settings + repository combined) - Final 'repositories' local: assembles all configurations Benefits: - Reduces cognitive complexity from ~10 to ~4 - Each step is independent and easier to debug - Clear comments explain priority and merge strategies - Maintains 100% backwards compatibility - All 30 tests passing Closes task 1.2 from IMPROVEMENT_PROPOSALS.md
…ility Add 5 new summary outputs to provide high-level governance insights: New Outputs: - organization_settings_summary: Organization configuration details - repositories_summary: Statistics by visibility, archived, templates - repositories_security_posture: Security features adoption across repos - runner_groups_summary: Runner groups and scale sets deployment metrics - governance_summary: Complete governance posture overview Benefits: - Dashboard-ready metrics for monitoring - Quick visibility into security posture - Capacity planning insights for runners - Better understanding of repository distribution - All 30 tests passing with null-safe conditions Technical improvements: - Null-safe conditional expressions (== true) - Empty list handling for sum() function - Proper module output access (r.repository.field) Closes task 1.3 from IMPROVEMENT_PROPOSALS.md Completes all Semana 1 Critical tasks (4/4) 🎉
- Add 10 tests for github_repository_collaborators (460 lines) * Basic team/user collaborators * Mixed collaborators (teams + users) * Inherited from settings * Merged settings + repository * Settings enforcement policy * All permission levels (pull, triage, push, maintain, admin) * Multiple repositories validation - Add 15 tests for github_repository_dependabot_security_updates (443 lines) * Enable/disable scenarios * Inheritance from settings * Settings enforcement (settings > repository > defaults) * Priority order validation * Integration with vulnerability_alerts and advanced_security * Default behavior and template repos * Archived repos and project mode - Clarify priority order in main.tf comments * settings > repository > defaults (policy enforcement) * Consistent across coalesce_keys, merge_keys, union_keys * Settings allows organization-wide governance enforcement - Update EXPERT_ANALYSIS_V2.md * Mark testing coverage gaps as completed ✅ * Document 124 total tests (100% pass rate) Total: +3,006 lines (tests + analysis documentation) All 124 tests passing ✅
- examples/large-scale/: Enterprise-scale deployment with 100+ repositories - 40 backend microservices organized by domain - 20 frontend applications - 15 infrastructure repositories - 15 data & analytics pipelines - 10 mobile applications - 5 public documentation repositories - DRY configuration using settings cascade - Organization-wide rulesets for compliance - Team-based access control - Performance optimized for 100-200 repos - examples/rulesets-advanced/: Complete GitHub ruleset reference - 20 edge case categories demonstrating ALL ruleset features - All enforcement levels (active, evaluate, disabled) - Complex ref patterns (~DEFAULT_BRANCH, ~ALL, wildcards) - All bypass actor types - Comprehensive PR rules and status checks - Commit/author/committer email patterns - Branch and tag name patterns (all operators) - Boolean rules (creation, deletion, update, etc.) - Required deployments and code scanning - Pattern negation and special regex characters - Copy-paste ready configurations for production use - examples/README.md: Comprehensive guide to all examples - Example selection guide - Performance characteristics - Common customization patterns - Troubleshooting guidance Updated EXPERT_ANALYSIS_V2.md roadmap to reflect completion of performance and edge cases work using practical examples instead of mock provider tests. Total: +3,548 lines across 12 files
- Fix deployment_branch_policy missing custom_branch_policies - Fix ruleset bypass_actors team format (use organization_admins instead) - Fix required_status_checks attribute name (required_checks not required_status_checks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.