-
Notifications
You must be signed in to change notification settings - Fork 120
add systemd units #94
base: master
Are you sure you want to change the base?
Conversation
@@ -125,8 +125,11 @@ | |||
'packages/examples/iotcc_thermistor_simulated.py']), | |||
(os.path.abspath(os.sep) + '/../etc/liota/packages/edge_systems/dell5k', | |||
['packages/edge_systems/dell5k/edge_system.py']), | |||
(os.path.abspath(os.sep) + '/../etc/liota/scripts', | |||
(os.path.abspath(os.sep) + '/../etc/liota/scripts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the new dependencies in Manifest.in file
ExecStart=/etc/liota/packages/liotad.py | ||
|
||
[Install] | ||
WantedBy=multi-user.target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I`m not sure but I think better to add a new line in both the files liotad.service & liotad.socket
http://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
Fixed endlines and added deps to the manifest file |
README.md
Outdated
### On systemd based systems: | ||
|
||
```bash | ||
$ systemctl enable liota.socket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be liotad.service & liotad.socket?
Also, I cloned your branch and will try out this commands on Fedora VM. What is the prime job of these commands? Also, I think if liota daemon gets started then we won`t require liotad.socket to be started explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be very helpful if you can provide some information about this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct. Fixing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tompscanlan Can you please answer the questions marked in the pull request?
@tompscanlan any update on this PR? |
add systemd start up configuration for liota