Skip to content

refactor: enforce Rust dead code and visibility lints #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: enforce Rust dead code and visibility lints #2564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd26bba
refactor: harden Rust visibility checks
fengmk2 Aug 26, 2026
6eb1972
fix: read both Cargo workspace manifests
fengmk2 Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ jobs:
cache-key: test
tools: just

- run: cargo check --all-targets --all-features
- run: cargo check --workspace --all-targets --all-features
env:
RUSTFLAGS: '-D warnings --cfg tokio_unstable' # also update .cargo/config.toml

Expand Down Expand Up @@ -201,7 +201,7 @@ jobs:
;;
esac
export CARGO_TARGET_X86_64_PC_WINDOWS_MSVC_RUSTFLAGS="$CARGO_TARGET_X86_64_PC_WINDOWS_MSVC_RUSTFLAGS -D warnings"
cargo check --all-targets --all-features --target x86_64-pc-windows-msvc
cargo check --workspace --all-targets --all-features --target x86_64-pc-windows-msvc

# Keep the package selection in sync with the `test` recipe in justfile.
# vp_cli_snapshots is excluded there too: its snapshot suite needs a
Expand Down Expand Up @@ -336,7 +336,7 @@ jobs:
components: clippy rust-docs rustfmt

- run: |
cargo shear
cargo shear --exclude 'rolldown*' --exclude string_wizard
cargo fmt --check
cargo fmt --manifest-path crates/vp_trampoline/Cargo.toml --check
just lint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prepare_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
update_toml crates/vp_global_cli/Cargo.toml

- name: Refresh Cargo.lock
run: cargo check
run: cargo check --workspace --all-targets --all-features

- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
id: app-token
Expand Down
2 changes: 2 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ Reference these files instead of duplicating rules here:

Prefer shared output helpers for user-facing messages and match nearby command style. New Rust code should satisfy the custom clippy restrictions.

Use the narrowest Rust visibility that fits the consumer. Reserve `pub` for APIs that another crate or external runtime intentionally consumes. Prefer private items, then `pub(super)` or `pub(crate)`, for implementation details. Add a crate-root `pub use` only when it is part of the intended crate API.

### TypeScript

Reference these files instead of duplicating rules here:
Expand Down
Loading
Loading