fix: avoid unnecessary napi6 feature activation - #638
Merged
Conversation
Co-authored-by: GPT-5 Codex <codex@openai.com>
fspy benchmarklinuxmacoswindows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
vt_client_napidoes not use N-API 6-only APIs. Keepingnapi6enabled became observable to downstream workspaces after the addon moved from a build dependency to a normal artifact dependency: Cargo now unifies it into their normal N-API feature graph.In Vite+, that feature unification exposes
ValueType::BigIntin Rolldown's N-API build and breaks its exhaustive match. Remove the unnecessary feature so downstream consumers keep their intended N-API surface.