fix(shell): preserve pathname expansion in scripts - #705
Open
RSS1102 wants to merge 5 commits into
Open
Conversation
RSS1102
force-pushed
the
rss1102/fix-package-script-shell-globs
branch
3 times, most recently
from
August 31, 2026 03:23
477b3b7 to
150b596
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
RSS1102
force-pushed
the
rss1102/fix-package-script-shell-globs
branch
from
August 31, 2026 09:04
150b596 to
31ac7b6
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
RSS1102
marked this pull request as ready for review
September 1, 2026 03:06
Author
|
This PR preserves the native package-script behavior on each platform:
Windows "lint": "vp lint \"packages/*/src\""Quoting ensures that vp lint receives the same pattern on every platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Package scripts rely on platform-specific shell semantics. On Unix, Vite Task's static command path flattened unquoted patterns such as
packages/*/srcinto literal arguments instead of allowing the package-script shell to perform pathname expansion, sovp runbehaved differently from package managers.The task runner should preserve those native semantics without introducing its own cross-platform glob language. Commands that want portable glob behavior can own it explicitly by receiving a quoted pattern unchanged, for example
vp lint "packages/*/src".Fixes #573.
Summary
cmd.exedoes not expand pathname patternsvt run, quoted command-owned patterns, extra arguments, exit codes, and platform-specific behavior with regression tests