Skip to content

Add PHP 8.5 CI coverage and regression tests for combined parser metadata collection#86

Merged
voku merged 8 commits intomasterfrom
copilot/add-tests-for-php-parser-validation
Apr 11, 2026
Merged

Add PHP 8.5 CI coverage and regression tests for combined parser metadata collection#86
voku merged 8 commits intomasterfrom
copilot/add-tests-for-php-parser-validation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

  • Root-cause: on PHP 8.5 ReflectionProperty::getHooks() returns a non-empty but incomplete hooks array for promoted properties (expression-form get => is missing), blocking the AST-based fallback in mergePromotedPropertyData
  • Fixed mergePromotedPropertyData in PHPClass to always prefer AST hooks when the AST param has any (removed the $existingProperty->hooks === [] guard)
  • Ran PHPUnit (68/68 pass) + PHPStan (0 errors)

@sonarqubecloud
Copy link
Copy Markdown

Copilot finished work on behalf of voku April 11, 2026 20:24
@voku voku marked this pull request as ready for review April 11, 2026 20:31
@voku voku merged commit 605f079 into master Apr 11, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants