Repository navigation
Conversation
Avoid resolving absolute schema URIs against synthetic combined-schema bases, which produces unreadable schemaservice URLs. Add regression tests for absolute URIs, relative and embedded paths, combined schemas, and retained validation diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default YAML workspace resolver treats absolute schema URIs as relative paths and passes them to
Utils.resolvePath().When combining multiple schemas, this can turn a valid URI such as
file:///c:/schemas/frontmatter.jsoninto:schemaservice://combinedschema/file%3A/c%3A/schemas/frontmatter.jsonThe resulting URI cannot be loaded, producing an “Unable to load schema … No content” diagnostic.
This was reproduced in the Slidev VS Code extension on Windows.
Fix
Return references with an explicit URI scheme unchanged. Relative references continue through the existing resolution logic, including embedded-document handling.
Tests
Add 19 regression cases covering:
Verified locally on Windows:
pnpm test— all 20 tests pass.pnpm run buildpnpm run lint