Skip to content

feat: add ModelServing eviction protection - #1484

Closed
avinxshKD wants to merge 2 commits into
volcano-sh:mainfrom
avinxshKD:fix/modelserving-eviction-protection
Closed

feat: add ModelServing eviction protection#1484
avinxshKD wants to merge 2 commits into
volcano-sh:mainfrom
avinxshKD:fix/modelserving-eviction-protection

Conversation

@avinxshKD

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Adds configurable eviction protection to ModelServing workloads.

Operators can preserve either a minimum number of ready ServingGroups or a minimum number of available instances for specific roles. The controller manages PodDisruptionBudgets for the protected ServingGroups or role instances.

Which issue(s) this PR fixes:

Fixes #1481

Bug evidence (required for bug-related PRs):

N/A

Special notes for your reviewer:

PDBs count Pods, while a ServingGroup or role instance can contain multiple Pods. This change creates a PDB for each protected logical unit so an eviction cannot partially disrupt it.

Does this PR introduce a user-facing change?:

Add configurable ServingGroup and role-level eviction protection for ModelServing workloads.

Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
Copilot AI review requested due to automatic review settings August 3, 2026 07:16
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yaozengzeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@LiZhenCheng9527

LiZhenCheng9527 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Have you verified this feature?
This is a very important feature in a production environment.

Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
@avinxshKD

Copy link
Copy Markdown
Contributor Author

Have you verified this feature? This is a very important feature in a production environment.

sir, the controller and validation tests r passing. Im working through the full node-drain and concurrent eviction scenarios now. I'll share the results here once the verification is complete.

Copilot AI review requested due to automatic review settings August 3, 2026 07:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@katara-Jayprakash

Copy link
Copy Markdown
Member

@avinxshKD ditto #1485

@kube-gopher

kube-gopher commented Aug 8, 2026

Copy link
Copy Markdown
Member

@avinxshKD Sorry, this has already been taken care of by #1485. It has been validated and tested in both the production environment and on Kind clusters. To keep the PR clean, I will go ahead and close this one. Thank you for your contribution.

@avinxshKD

Copy link
Copy Markdown
Contributor Author

@avinxshKD Sorry, this has already been taken care of by #1485. It has been validated and tested in both the production environment and on Kind clusters. To keep the PR clean, I will go ahead and close this one. Thank you for your contribution.

thankyou sir will be learing from and watching that PR, closing this

@avinxshKD avinxshKD closed this Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ModelServing-aware eviction protection for safe node drain

6 participants