docs(router): align observability contract - #1500
Conversation
volcano-sh-bot
added
the
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@LiZhenCheng9527 Observability Optimization 2 |
|
#1500 a milestone number 😄 |
😄 |
| # Router Access Log Fields Reference | ||
|
|
||
| This document provides a comprehensive reference for all fields available in Kthena Router access logs. | ||
| Kthena emits one access-log entry after each routed inference request. The |
There was a problem hiding this comment.
The access-log middleware skips every path outside /v1/, while handleHTTPRoute explicitly supports non-/v1/ routes. Those inference requests emit no access record, so this should document the limitation or avoid saying every routed request is logged.
| | `/debug/config_dump/namespaces/{ns}/modelservers/{name}` | Detailed single ModelServer | | ||
|
|
||
| ## Quick Start – Observability in Action | ||
| Application logs and access logs share the configured output. The following |
There was a problem hiding this comment.
ACCESS_LOG_OUTPUT only controls access logs; klog writes application logs independently, and file output will not appear in kubectl logs. This explanation should be scoped to stdout/stderr destinations.
Signed-off-by: kube-gopher <jzlyy68@gmail.com>
c67c0cc to
b8f62a1
Compare
|
/lgtm |
3 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1499
Bug evidence (required for bug-related PRs):
Special notes for your reviewer:
Does this PR introduce a user-facing change?: