Skip to content

test(router): prevent observability contract drift - #1511

Open
kube-gopher wants to merge 1 commit into
volcano-sh:mainfrom
kube-gopher:test/observability-drift-prevention
Open

test(router): prevent observability contract drift#1511
kube-gopher wants to merge 1 commit into
volcano-sh:mainfrom
kube-gopher:test/observability-drift-prevention

Conversation

@kube-gopher

Copy link
Copy Markdown
Member

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

  • render the Helm chart with non-default ports and both HTTP and TLS settings, then verify router container/Service port wiring and health/readiness probes;
  • assert the exact JSON field set emitted by a fully populated access-log entry and the required fields retained for a minimal entry;
  • parse the example Grafana dashboard as JSON and verify every referenced kthena_router_* PromQL metric name maps to a registered collector, including histogram _bucket, _count, and _sum series;
  • verify router metric names listed in the canonical observability guide map to registered router collectors.

Which issue(s) this PR fixes:
Fixes #1510

Bug evidence (required for bug-related PRs):

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: kube-gopher <jzlyy68@gmail.com>
@volcano-sh-bot volcano-sh-bot added the kind/enhancement New feature or request label Aug 6, 2026
@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lizhencheng9527 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kube-gopher

Copy link
Copy Markdown
Member Author

Previously, there were instances of obsolescence or disconnects among related documents, metrics, Helm charts, and so on, so I added an automatic detection and discovery mechanism; for example : #1499

@kube-gopher

Copy link
Copy Markdown
Member Author

/cc @YaoZengzeng @acsoto

@kube-gopher

Copy link
Copy Markdown
Member Author

From a long-term perspective, I think it's worth it because there's no need for manual review

@LiZhenCheng9527

Copy link
Copy Markdown
Member

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add automated checks for router observability contract drift

3 participants