Skip to content

Fix vLLM ZMQ topic filter - #1534

Merged
volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
avinxshKD:fix/vllm-zmq-topic-filter
Aug 10, 2026
Merged

Fix vLLM ZMQ topic filter#1534
volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
avinxshKD:fix/vllm-zmq-topic-filter

Conversation

@avinxshKD

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

The vLLM ZMQ subscriber already subscribes to the topic configured by VLLM_ZMQ_TOPIC_FILTER, but the message filtering path still compared incoming topics against the hardcoded kv-events topic.

That made non-default topic filters silently drop valid messages after they were received from ZMQ.

This PR makes the vLLM subscriber use the configured topic for the application-level topic check, matching the existing SGLang subscriber behavior.

Which issue(s) this PR fixes:
Fixes #1527

Bug evidence (required for bug-related PRs):

Set VLLM_ZMQ_TOPIC_FILTER=test-topic and publish a normal 3-part vLLM ZMQ message with topic test-topic.

Before this change:

  • the SUB socket subscribes to test-topic
  • the frame is received from ZMQ
  • the application-level check drops it because the code compares the topic with hardcoded kv-events
  • the event is never processed

The broken path was:

topic, payload = self._extract_message_data(parts)
if not topic or topic != "kv-events":
    continue

After this change, the same application-level check uses self.config.zmq_topic_filter, so the topic used by the SUB socket and the topic accepted by the subscriber stay consistent.

A regression test covers the non-default topic case and verifies that a message on the configured topic is processed while a different topic is ignored.

Special notes for your reviewer:
The change intentionally mirrors the existing SGLang ZMQ subscriber topic-filter handling.

Does this PR introduce a user-facing change?:

Fixed vLLM ZMQ event subscriber topic filtering to honor VLLM_ZMQ_TOPIC_FILTER during message processing.

Copilot AI lite review requested due to automatic review settings August 8, 2026 05:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@avinxshKD

Copy link
Copy Markdown
Contributor Author

Hey @FAUST-BENCHOU @acsoto PTAL. Kept this intentionally small, mirrors the SGLang topic check and added a narrow regression for non-default vLLM topics.

cc @LiZhenCheng9527 @YaoZengzeng

Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
@avinxshKD
avinxshKD force-pushed the fix/vllm-zmq-topic-filter branch from 08a4fbf to 2eb44bd Compare August 8, 2026 05:47
Copilot AI review requested due to automatic review settings August 8, 2026 05:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@acsoto

acsoto commented Aug 8, 2026

Copy link
Copy Markdown
Member

/lgtm

@LiZhenCheng9527

Copy link
Copy Markdown
Member

/approve

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
volcano-sh-bot merged commit daa41c2 into volcano-sh:main Aug 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runtime: vLLM KV-event subscriber ignores configured zmq_topic_filter (hardcoded "kv-events")

5 participants