Fix vLLM ZMQ topic filter - #1534
Merged
volcano-sh-bot merged 1 commit intoAug 10, 2026
Merged
Conversation
Contributor
Author
|
Hey @FAUST-BENCHOU @acsoto PTAL. Kept this intentionally small, mirrors the SGLang topic check and added a narrow regression for non-default vLLM topics. |
Signed-off-by: Avinash Kumar Deepak <avinash8655279@gmail.com>
avinxshKD
force-pushed
the
fix/vllm-zmq-topic-filter
branch
from
August 8, 2026 05:47
08a4fbf to
2eb44bd
Compare
Member
|
/lgtm |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The vLLM ZMQ subscriber already subscribes to the topic configured by
VLLM_ZMQ_TOPIC_FILTER, but the message filtering path still compared incoming topics against the hardcodedkv-eventstopic.That made non-default topic filters silently drop valid messages after they were received from ZMQ.
This PR makes the vLLM subscriber use the configured topic for the application-level topic check, matching the existing SGLang subscriber behavior.
Which issue(s) this PR fixes:
Fixes #1527
Bug evidence (required for bug-related PRs):
Set
VLLM_ZMQ_TOPIC_FILTER=test-topicand publish a normal 3-part vLLM ZMQ message with topictest-topic.Before this change:
test-topickv-eventsThe broken path was:
After this change, the same application-level check uses self.config.zmq_topic_filter, so the topic used by the SUB socket and the topic accepted by the subscriber stay consistent.
A regression test covers the non-default topic case and verifies that a message on the configured topic is processed while a different topic is ignored.
Special notes for your reviewer:
The change intentionally mirrors the existing SGLang ZMQ subscriber topic-filter handling.
Does this PR introduce a user-facing change?: