Repository navigation
fix(langchain): skip projection for empty Store index fields - #6965
Closed
stefanielizeth73-art wants to merge 1 commit into
Closed
stefanielizeth73-art wants to merge 1 commit into
stefanielizeth73-art wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for preparing this change and its documentation and validation. As clarified in #6962, we are keeping the OpenViking Store integration focused on semantic indexing and retrieval. We are not taking on additional compatibility behavior for store-only, non-semantic use cases, including making We are closing this PR without merging based on that maintenance scope. We appreciate the time you spent investigating and implementing the change. |
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An empty Store field selection (
index=[]) still created a Markdown search projection containing the key and namespace. Updating an indexed item with an empty selection also retained a searchable projection.Apply the existing
index=Falseremoval path to an empty effective field list. Constructor defaults and write overrides behave consistently; the JSON value remains readable throughget()and nonsemantic search. Nonempty selectors are unchanged.Human Involvement
Implementation, self-review, and local validation were completed with Codex assistance. Human code review is pending.
Related Issue
Fixes #6962.
Type of Change
Changes Made
Testing
Windows / Python 3.13.9; LangGraph 1.2.15, langchain-core 1.6.10, LangChain 1.4.0; based on main
66e8ff0a.Commands:
Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
Validation uses controlled storage/search clients, without live server, vector-provider, or model calls. The two full-suite failures are
test_resolve_resource_source_handles_local_and_remote_sourcesandtest_add_resource_keeps_explicit_local_clients_supported.