Repository navigation
feat(langchain): manage Store-owned client lifecycle - #6968
Merged
qin-ctx merged 1 commit intoNov 4, 2026
Merged
Conversation
qin-ctx
approved these changes
Nov 4, 2026
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenVikingStore(url=...)retained an internally created HTTP client without a public release method. Addclose(),aclose(), and synchronous/asynchronous context managers, using the integration's existing client-ownership rule.Cleanup is idempotent, releases only internally created clients, and preserves lazy creation for unused Stores. Async cleanup runs off the event loop. Closed Stores reject further operations, including directory queries that would otherwise hide the closed-state error as an empty result. Injected clients remain caller-owned.
Human Involvement
Implementation, self-review, and local validation were completed with Codex assistance. Human code review is pending.
Related Issue
Closes #6964.
Type of Change
Changes Made
Testing
Windows / Python 3.13.9; LangGraph 1.2.15, langchain-core 1.6.10, LangChain 1.4.0; based on main
66e8ff0a.Commands:
Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
This is an additive client-lifecycle API; persisted values and search/index semantics are unchanged. Cleanup reuses the existing owned handle's behavior. Validation uses controlled clients without live server or model calls. The unchanged full-suite failures are
test_resolve_resource_source_handles_local_and_remote_sourcesandtest_add_resource_keeps_explicit_local_clients_supported.