fix(tel-link): handle non-digit characters

volkmann-design-code · Apr 11, 2024 · 3b3a766 · 3b3a766
1 parent ab7d0f9
commit 3b3a766
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/UrlHelpers.php b/src/UrlHelpers.php
@@ -6,7 +6,7 @@ class UrlHelpers {
 
     static function telLink(string $phoneNumber): string
     {
-        return 'tel:' . str_replace(' ', '', $phoneNumber);
+        return 'tel:' . preg_replace('/[^\d+]/', '', $phoneNumber);
     }
 
     static function mailtoLink(string $email): string

diff --git a/tests/UrlHelpersTest.php b/tests/UrlHelpersTest.php
@@ -11,6 +11,27 @@ public function testTelLink(): void
         $this->assertSame($res, 'tel:12345');
     }
 
+    public function testTelLinkWhitespace(): void
+    {
+        $phone = '0123 4567 8910';
+        $res = UrlHelpers::telLink($phone);
+        $this->assertSame($res, 'tel:012345678910');
+    }
+
+    public function testTelLinkCharacters(): void
+    {
+        $phone = '0123 / 4567 8910';
+        $res = UrlHelpers::telLink($phone);
+        $this->assertSame($res, 'tel:012345678910');
+    }
+
+    public function testTelLinkCountryPrefix(): void
+    {
+        $phone = '+49 123 / 4567 8910';
+        $res = UrlHelpers::telLink($phone);
+        $this->assertSame($res, 'tel:+4912345678910');
+    }
+
     public function testMailtoLink(): void
     {
         $mail = '[email protected]';