Skip to content

skip[ci]: remove debug-assertions=yes from codspeed runs#7252

Merged
joseph-isaacs merged 1 commit into
developfrom
ji/remove-deubg-assert-codspeed
Apr 1, 2026
Merged

skip[ci]: remove debug-assertions=yes from codspeed runs#7252
joseph-isaacs merged 1 commit into
developfrom
ji/remove-deubg-assert-codspeed

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

This was accidentally added in #5440

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) April 1, 2026 17:26
@joseph-isaacs joseph-isaacs added the changelog/skip Do not list PR in the changelog label Apr 1, 2026
@codspeed-hq

codspeed-hq Bot commented Apr 1, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.2%

⚡ 810 improved benchmarks
❌ 1 regressed benchmark
✅ 295 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_dict_primitive_canonical_into[f32, (1000, 100, 10)] 139.5 µs 117.3 µs +18.98%
Simulation chunked_bool_canonical_into[(10, 1000)] 2.2 ms 1.9 ms +14.84%
Simulation chunked_bool_canonical_into[(1000, 10)] 83.8 µs 71.1 µs +17.88%
Simulation chunked_dict_primitive_canonical_into[u32, (1000, 100, 100)] 1,113.7 µs 936.9 µs +18.87%
Simulation chunked_bool_canonical_into[(100, 100)] 255.9 µs 219.2 µs +16.73%
Simulation chunked_dict_primitive_canonical_into[u32, (1000, 1000, 10)] 154.4 µs 134.1 µs +15.15%
Simulation chunked_dict_primitive_canonical_into[f32, (1000, 10, 100)] 1,092.2 µs 915.1 µs +19.35%
Simulation chunked_dict_primitive_canonical_into[f32, (1000, 10, 10)] 136.2 µs 115.7 µs +17.74%
Simulation chunked_dict_primitive_canonical_into[f32, (1000, 100, 100)] 1,112.3 µs 933.4 µs +19.17%
Simulation chunked_dict_primitive_canonical_into[u32, (1000, 100, 10)] 139 µs 117.3 µs +18.54%
Simulation chunked_dict_primitive_canonical_into[u64, (1000, 100, 10)] 180.4 µs 146.4 µs +23.23%
Simulation chunked_dict_primitive_canonical_into[f32, (1000, 1000, 10)] 154.2 µs 133.7 µs +15.34%
Simulation chunked_dict_primitive_canonical_into[f64, (1000, 1000, 10)] 214.4 µs 180.6 µs +18.71%
Simulation chunked_opt_bool_canonical_into[(10, 1000)] 2.5 ms 2.2 ms +14.61%
Simulation chunked_dict_primitive_canonical_into[u64, (1000, 10, 10)] 177.2 µs 143.4 µs +23.61%
Simulation chunked_constant_utf8_append_to_builder[("hi", 1000, 10)] 511.9 µs 142 µs ×3.6
Simulation chunked_dict_primitive_canonical_into[u64, (1000, 10, 100)] 1.5 ms 1.2 ms +27.22%
Simulation chunked_dict_primitive_canonical_into[u32, (1000, 1000, 100)] 1.3 ms 1.1 ms +15.83%
Simulation chunked_dict_primitive_canonical_into[u64, (1000, 1000, 10)] 214.6 µs 180.2 µs +19.1%
Simulation chunked_dict_primitive_canonical_into[f64, (1000, 1000, 100)] 1.9 ms 1.5 ms +20.75%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ji/remove-deubg-assert-codspeed (f922dbf) with develop (19403db)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs merged commit fcfd443 into develop Apr 1, 2026
111 of 115 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/remove-deubg-assert-codspeed branch April 1, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants