vortex-io: Add explicit span on spawn_io#8232
Merged
Merged
Conversation
I/O tasks are likely to cause a lot of tracing to be produced. With an explicit span on them, we can control it more precisely. Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
AdamGS
approved these changes
Jun 3, 2026
Merging this PR will improve performance by 20.94%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
246.1 ns | 275.3 ns | -10.6% |
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
45.4 µs | 30.4 µs | +49.27% |
| ⚡ | Simulation | baseline_eq[4, 65536] |
237.8 µs | 185 µs | +28.54% |
| ⚡ | Simulation | baseline_lt[16, 65536] |
275.4 µs | 217.5 µs | +26.63% |
| ⚡ | Simulation | baseline_lt[4, 65536] |
253 µs | 200.8 µs | +26.01% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
197.7 µs | 161.4 µs | +22.44% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
212.3 µs | 176 µs | +20.64% |
| ⚡ | Simulation | baseline_eq[16, 65536] |
260.2 µs | 229.8 µs | +13.23% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing polarsignals:trace-vortex-io (a7fba5f) with develop (7a53ad5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I/O tasks are likely to cause a lot of tracing to be produced. With an explicit span on them, we can control it more precisely.
API Changes
No API changes.
Testing
No testing, this just allows consumers to configure tracing at a more granular level.
@AdamGS