Skip to content

Add Validity::definitely_all_invalid and use it for AllInvalid fast paths#8335

Closed
joseph-isaacs wants to merge 2 commits into
claude/cool-bardeen-l8jlsy-2-mask-eqfrom
claude/cool-bardeen-l8jlsy-3-definitely-all-invalid
Closed

Add Validity::definitely_all_invalid and use it for AllInvalid fast paths#8335
joseph-isaacs wants to merge 2 commits into
claude/cool-bardeen-l8jlsy-2-mask-eqfrom
claude/cool-bardeen-l8jlsy-3-definitely-all-invalid

Remove unused Validity import in vortex-cuda dynamic dispatch

a13f0ab
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis succeeded Jun 11, 2026 in 0s

Performance Gate Passed

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 5 improved benchmarks
✅ 1527 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 35.4 µs 20.5 µs +72.8%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 213.1 µs 176.8 µs +20.53%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation chunked_varbinview_canonical_into[(100, 100)] 308.4 µs 273.1 µs +12.94%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/cool-bardeen-l8jlsy-3-definitely-all-invalid (a13f0ab) with claude/cool-bardeen-l8jlsy-2-mask-eq (3542eaf)

Open in CodSpeed