fix[gpu]: decode extension arrays on the GPU#8353
Merged
Merged
Conversation
Extension arrays match AnyCanonical regardless of how their storage is encoded, so execute_cuda returned them via the canonical early-return and compressed storage (e.g. ext(date) -> fastlanes.for -> fastlanes.bitpacked) was never decoded by a GPU kernel. Recurse into the storage array before the canonical check, mirroring the existing Struct field recursion. Fixes #8143 Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
b6c0c61 to
2d6871c
Compare
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
20.2 µs | 35.2 µs | -42.51% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
177.2 µs | 213.3 µs | -16.93% |
| ❌ | Simulation | varbinview_large |
113.1 µs | 131.7 µs | -14.14% |
| ❌ | Simulation | decompress_rd[f64, (100000, 0.0)] |
845.2 µs | 980 µs | -13.76% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
215.3 ns | 244.4 ns | -11.93% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
274.4 µs | 309.3 µs | -11.27% |
| ⚡ | Simulation | decompress_rd[f64, (10000, 0.0)] |
138 µs | 110.9 µs | +24.41% |
| ⚡ | Simulation | decompress_rd[f64, (10000, 0.1)] |
137.8 µs | 110.9 µs | +24.24% |
| ⚡ | Simulation | decompress_rd[f64, (10000, 0.01)] |
137.4 µs | 110.6 µs | +24.23% |
| ⚡ | Simulation | decompress_rd[f32, (10000, 0.1)] |
89.3 µs | 80.2 µs | +11.4% |
| ⚡ | Simulation | decompress_rd[f32, (10000, 0.0)] |
89.6 µs | 80.8 µs | +10.93% |
| ⚡ | Simulation | decompress_rd[f32, (10000, 0.01)] |
89.3 µs | 80.7 µs | +10.66% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ad/gpu-decode-ext-storage (2d6871c) with develop (3d7bbfb)
onursatici
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8143