Skip to content

perf[mask]: check AllTrue/AllFalse in eq#8354

Merged
joseph-isaacs merged 1 commit into
developfrom
ji/eq-mask-fast
Jun 11, 2026
Merged

perf[mask]: check AllTrue/AllFalse in eq#8354
joseph-isaacs merged 1 commit into
developfrom
ji/eq-mask-fast

Conversation

@joseph-isaacs

Copy link
Copy Markdown
Contributor

If two Mask::AllTrue or AllFalse are passed we don't need a bit buffer to check equality

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs requested a review from a team June 11, 2026 10:29
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) June 11, 2026 10:29
@joseph-isaacs joseph-isaacs requested a review from 0ax1 June 11, 2026 10:29
@0ax1 0ax1 added the changelog/performance A performance improvement label Jun 11, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 5 improved benchmarks
❌ 3 regressed benchmarks
✅ 1524 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 20.6 µs 35.6 µs -42.13%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 162.1 µs 198.2 µs -18.21%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 177.2 µs 213.1 µs -16.84%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation encode_varbin[(1000, 8)] 160.8 µs 143.8 µs +11.78%
Simulation encode_varbin[(1000, 4)] 160 µs 143.2 µs +11.78%
Simulation encode_varbin[(1000, 32)] 165.4 µs 148.8 µs +11.13%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ji/eq-mask-fast (77659f0) with develop (1082a5d)

Open in CodSpeed

@joseph-isaacs joseph-isaacs merged commit b94291b into develop Jun 11, 2026
94 of 106 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/eq-mask-fast branch June 11, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants