Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 merge #36

Draft
wants to merge 369 commits into
base: master
Choose a base branch
from
Draft

2.0 merge #36

wants to merge 369 commits into from

Conversation

lsirivong
Copy link

Just documenting this WIP

jhchen and others added 30 commits September 8, 2019 21:43
- convert to non-deprecated <s> tag
- mirror bold/italic's implementation
right before mutation events are fired the tags will swap places, can
confirm by logging synchronous MutationEvent
There is a small typo in docs/1.0/docs/api/contents.md, docs/docs/api/contents.md.

Should read `returning` rather than `returing`.
Fix-up "initization": should be "initialization"
Currently our editor listens on the common hotkeys (cmd+z / cmd+shift+z)
for undo/redo but the user could always undo using native browser UI
like right-click, the edit topbar menu, and on mobile iOS there is a toolbar,
and the native undo usually does not do the right thing.

Most modern browsers support `beforeinput` to interrupt native undo/redo inputs
so we'll use this to handle them natively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.