Skip to content

modulesync 9.5.0 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 34 commits into from
Closed

modulesync 9.5.0 #465

wants to merge 34 commits into from

Conversation

Valantin
Copy link
Contributor

Pull Request (PR) description

lot of work to port openvpn module to last modulesync

This Pull Request (PR) fixes the following issues

#417

This Pull Request (PR) include the following PR

#441
#445
#446
#447
#448
#449
#453
#457
#458
#459
#460
#461
#463

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big PR that's hard to review. I only looked at part of it but need to head into a meeting so submitting what I already noted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does Rocky package it differently from Red Hat? That amazes me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to know too but thats it

binaryv2 = '/usr/share/easy-rsa/2.0/pkitool'
binaryv3 = '/usr/share/easy-rsa/3/easyrsa'
when %r{Ubuntu|Debian}
case operatingsystemrelease
when %r{9|10|11|18.04|20.04|22.04}
when %r{9|10|11|12|18.04|20.04|22.04|24.04}
binaryv2 = '/usr/share/easy-rsa/pkitool'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still anything that uses the v2 tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked into it yet, but I plan to remove the easyrsa2 support in a future PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to remove easyrsa2 and possibly the whole selection if you're changing Debian to version 3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just solaris stay on version 2 because I didn't test it and don't find a PR to move it to 3, the default was moved to 3

@Valantin
Copy link
Contributor Author

This is a big PR that's hard to review. I only looked at part of it but need to head into a meeting so submitting what I already noted.

Sorry for this, but is the only way to fix CI and update modulesync, if I split it in 16 PR just few pass the check.

@Valantin Valantin changed the base branch from modulesync to master April 24, 2025 14:41
@Valantin Valantin closed this Apr 28, 2025
@Valantin
Copy link
Contributor Author

reworked and splitted in #474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants