Add parameters latency_tracking & repl_diskless_sync #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
currently I don't understand why I got this failing in CI : |
TheMeier
force-pushed
the
add_parameters
branch
from
03aebb6 to
e722e04
Compare
TheMeier
reviewed
Aug 15, 2025
|
|
||
| $bind_arr = [$bind].flatten | ||
|
|
||
| $default_redis_version = '8.0.0' |
Contributor
There was a problem hiding this comment.
Do we really need the version magic?
Version facts are quite opaque and lead to non-idempotent behaviour
Author
There was a problem hiding this comment.
those new parameters are from version 7.0.0, so I was looking for a way to keep old setup working, and providing a new config file for setup with redis version > 7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
this PR add two parameters into redis.conf :
repl-diskless-sync
latency-tracking
https://raw.githubusercontent.com/redis/redis/7.0/redis.conf
This Pull Request (PR) fixes the following issues
Fixes #531