Parameterize appendonly and save_db_to_disk
#566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
changed the title
appendonly and save_db_to_disk
kenyon
requested changes
Nov 5, 2025
Member
kenyon
left a comment
kenyon
left a comment
There was a problem hiding this comment.
What is the purpose of this change? One can already set these values if desired.
bwitt
force-pushed
the
add-appendonly-save
branch
from
687084b to
7632df6
Compare
Contributor
Author
|
I was trying to allow for disabling redis append only file and snapshotting like it was mentioned in the issue; is this not needed? |
Member
|
If the values are the same for every OS in Adding tests is good though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow for setting appendonly and RDB snapshotting by making them params.
This Pull Request (PR) fixes the following issues
FIxes #321