Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React17に上げる #200

Merged
merged 10 commits into from
Jan 29, 2021
Merged

React17に上げる #200

merged 10 commits into from
Jan 29, 2021

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Nov 19, 2020 •
edited
Loading

close: #202

@youchann youchann added the dependencies Pull requests that update a dependency file label Nov 19, 2020
@youchann youchann self-assigned this Nov 19, 2020
@youchann
Copy link
Contributor Author

youchann commented Nov 19, 2020 •
edited
Loading

examples/配下でデバッグしているが、
<DropdownButton />や<Select />など、操作によってdomが追加されるコンポーネントがうまく動作せずcrashする。

なお、storybookではちゃんと動くのでバンドラーが怪しいと睨んでいる

@youchann
Copy link
Contributor Author

先にrollup周りを上げることにした。

@youchann
Copy link
Contributor Author

#201

youchann
youchann commented Nov 19, 2020
View reviewed changes
package.json
Comment on lines +38 to +39
"react": ">= 16.8.0 || ^17.0.1",
"react-dom": ">= 16.8.0 || ^17.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/styled-components/styled-components/blob/master/packages/styled-components/package.json#L77-L78

styled-componentsと同じにした。

youchann
youchann commented Nov 19, 2020
View reviewed changes
package.json
Comment on lines +88 to +90
"resolutions": {
"react": "^17.0.1",
"react-dom": "^17.0.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: https://numb86-tech.hatenablog.com/entry/2020/05/26/170627

@youchann
Copy link
Contributor Author

先走って
#201
を取り入れてみたけども、変わらず。

@youchann youchann marked this pull request as draft November 20, 2020 08:42
@youchann youchann mentioned this pull request Nov 20, 2020
Closed
@youchann youchann changed the title wip: React17に上げる React17に上げる Jan 28, 2021
@youchann youchann marked this pull request as ready for review January 29, 2021 01:08
@youchann youchann requested a review from a team as a code owner January 29, 2021 01:08
@youchann
Copy link
Contributor Author

#202 (comment)

一応こんな流れで検証はしたので問題なさそう。

@youchann
Copy link
Contributor Author

うーん、何か良い方法あれば仕組みにしたい...............

@youchann youchann requested a review from maktak1995 January 29, 2021 01:09
maktak1995
maktak1995 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！

@youchann youchann merged commit 0664470 into master Jan 29, 2021
@youchann youchann deleted the update-react-17 branch January 29, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maktak1995 maktak1995 maktak1995 approved these changes

Assignees

@youchann youchann

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update React v17
2 participants
@youchann @maktak1995