Easier to upgrade: Rename VPMAlias.txt #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Alias.cpp aliases into VPMAlias.txt Update the Github workflow to amend the content of VPMAlias.txt into the source code before compilation and include VPMAlias.txt as VPMAlias_template.txt in the zip file.
|
@jsm174, is there any special handling in standalone for Aliases? I have not found anything in this repository. |
|
Neat, thanks!! |
@JockeJarre - correct, libpinmame doesn't support aliases. I've always wanted to add it, but have not got around to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have now moved all aliases from Alias.cpp to VPMAlias.txt -> only one file to edit.
This file is now automatically integrated into Alias.cpp before compilation in the workflow. -> only one file to edit.
On assembly VPMAlias.txt is amended as VPMAlias_template.txt
All this means that VPMAlias.txt can start empty and end users only need to add personal entries.
Each update will become easier, since all files can be unzipped into the folder.