Skip to content

Conversation

@GeekoDev
Copy link

@GeekoDev GeekoDev commented Jul 7, 2022

This modification gives the possibility to include an xml file directly inside oc 4.x extension folder, the file must be into /extension/[module]/vqmod/ in order to work.
This way a package can be fully integrated with its modification into the module package, to avoid extra operation of uploading vqmod file by FTP.

For this it was necessary to modify the vqmod.php file, which is kind of ugly compared to have only an xml file to upload, but unfortunately I see no other way to do that, as we can't vqmod the vqmod :)

GeekoDev added 2 commits July 7, 2022 16:10
Make vqmod to also take xml files which are in /vqmod/ folder from each extension directory, this way once vqmod is installed we can load a module package with its vqmod file inside directly.
@JAY6390
Copy link

JAY6390 commented Jul 7, 2022

If I'm understanding this correctly, you want to have an entire vqmod.php file in the OC install version? I'm thinking there might be a cleaner way of doing this with an additional file that can be added that has a list of path patterns to look for the other vqmod xml files. That way, vqmod.php could be upgraded independently of the OC version

@GeekoDev
Copy link
Author

GeekoDev commented Jul 7, 2022

You're right, I just did something to handle that in clean way directly by using pathReplaces file, I will submit the pull request in vqmod.

GeekoDev added 4 commits July 7, 2022 18:30
pathReplaces.php file updated for latest vqmod update to support to include xml directly in OC4 module folder structure into extension/[mod]/vqmod/
@GeekoDev
Copy link
Author

GeekoDev commented Jul 7, 2022

Did it, see the pull request on main vqmod, I think it is quite clean this way, and we can use directly pathReplaces.php so no additional file necessary.

Sorry about README.md, I tried to restore original one but don't know I can remove the file from the pull request, if all ok for you please pull only the pathReplaces.php

@JAY6390
Copy link

JAY6390 commented Jul 9, 2022

Hi Geekodev

Thanks for that. I'm looking into creating an entirely new version of VQMod (3.0) with a couple of extra features. I'll include this as well as part of that release, and maybe a If you'd like to be an early tester for it, send me an email (as per the emails in the copyright) and I'll let you know when I have a copy.

Kind regards
Jay

@GeekoDev
Copy link
Author

Hi Jay,

That's great, you can use this email: [email protected]

@dennisbuijsgmailcom
Copy link

Hi
Very good idea, was also thinking of how we can achieve this using the oc4 extension installer.

I like to test is also, [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants