-
Notifications
You must be signed in to change notification settings - Fork 5
Possibility to have xml file directly into module folder on OC 4.x #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Make vqmod to also take xml files which are in /vqmod/ folder from each extension directory, this way once vqmod is installed we can load a module package with its vqmod file inside directly.
|
If I'm understanding this correctly, you want to have an entire vqmod.php file in the OC install version? I'm thinking there might be a cleaner way of doing this with an additional file that can be added that has a list of path patterns to look for the other vqmod xml files. That way, vqmod.php could be upgraded independently of the OC version |
|
You're right, I just did something to handle that in clean way directly by using pathReplaces file, I will submit the pull request in vqmod. |
pathReplaces.php file updated for latest vqmod update to support to include xml directly in OC4 module folder structure into extension/[mod]/vqmod/
|
Did it, see the pull request on main vqmod, I think it is quite clean this way, and we can use directly pathReplaces.php so no additional file necessary. Sorry about README.md, I tried to restore original one but don't know I can remove the file from the pull request, if all ok for you please pull only the pathReplaces.php |
|
Hi Geekodev Thanks for that. I'm looking into creating an entirely new version of VQMod (3.0) with a couple of extra features. I'll include this as well as part of that release, and maybe a If you'd like to be an early tester for it, send me an email (as per the emails in the copyright) and I'll let you know when I have a copy. Kind regards |
|
Hi Jay, That's great, you can use this email: [email protected] |
|
Hi I like to test is also, [email protected]. |
This modification gives the possibility to include an xml file directly inside oc 4.x extension folder, the file must be into /extension/[module]/vqmod/ in order to work.
This way a package can be fully integrated with its modification into the module package, to avoid extra operation of uploading vqmod file by FTP.
For this it was necessary to modify the vqmod.php file, which is kind of ugly compared to have only an xml file to upload, but unfortunately I see no other way to do that, as we can't vqmod the vqmod :)