-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(Image): Update preview toolbar #7117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@selicens 好久没动静,没人review和merge |
可能唐老师最近在忙其他的吧,除了button的那个pr比较紧急,其他的pr都还好不是太有关紧要 |
积累了不少pr了,一个月多没动静了。给人有一种会不会不维护了的错觉。落后ant-design5.x最新的越来越多了。可以问下唐老师,啥时候review |
…into feat-image-preview-toolbar
…into feat-image-preview-toolbar
…into feat-image-preview-toolbar
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Hello, Can we merge it ? What is the problem ? Regards, |
@selicens 这个其实可以考虑下次发版合并进去哦 |
还是没有动静吗?非常需要自定义Toolbar |
可以先通过打补丁的形式来使用 |
如何打补丁呢,按照教程打的补丁pnpm i时报错 ERR_PNPM_INVALID_PATCH: hunk header integrity check failed |
已解决 |
什么时候合并呢,已经半年了 |
预览界面和antd相比,滚轮放大有点不一样。antd会放大鼠标所在位置,目前pr是放大图片中心区域 |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
这里有计划合并吗? |
可以自行patch |
@selicens can you please share example how we can patch vue-ant-desig ourselves? |
目前的显示是右上角,从设计的出发点,无论是鼠标还是平板,都是比较友好的。 |
在feat-image-preview-toolbar分支,compile 一直报ts错,能把compile之后的image组件发一下吗 |
什么版本的,我仓库里合了一版4.2.3,没报错 |
感谢回复,我使用最新的4.2.6没报错了,但是patch的话要替换掉哪些文件呢,只需要Image组件就可以吗 |
我是原项目里使用pnpm patch [email protected],会生成一个文件夹, 然后你把你自己合的antdv项目打包(npm run pub),执行到最后会提示登录(关掉即可) |
好的,非常感谢,我去试试 |
合了最新的版本,然后给图片预览加了基于鼠标位置的缩放:selicens#2 |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
#7068
