Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(i18n-id): Provide Indonesian translation for migration - Part 2 #50

Merged
merged 5 commits into from
Nov 17, 2020

Conversation

Namchee
Copy link

@Namchee Namchee commented Nov 14, 2020

Gambaran Umum

Pull request ini merupakan bagian dari #23
Pull request ini menambahkan terjemahan Bahasa Indonesia untuk beberapa berkas dalam migration

Perubahan

Berikut merupakan berkas yang diterjemahkan

  • attrs-includes-class-style.md
  • children.md
  • custom-directives.md

Copy link
Member

@mandaputtra mandaputtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tolong package-lock.json untuk bisa dihapus? Kalau mau install tanpa merubah package-lock.json bisa gunakan npm ci.

Terjemahan sudah oke.

@Namchee
Copy link
Author

Namchee commented Nov 17, 2020

@mandaputtra package-lock.json sudah saya hapus (terinclude terus-menerus karena saya kebiasaan menggunakan git add .). Akankah lebih baik bila file tersebut ditambahkan di .gitignore?

@mandaputtra
Copy link
Member

Boleh silahkan ditambahkan, lagipula proyek juga menggunakan yarn.

@mandaputtra mandaputtra merged commit 0f3472e into vuejs-id:indonesian Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants