feat: invite user, admin setup #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuefes-2024 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jiyuujin
commented
Apr 30, 2024
| // for https on localhost | ||
| // devServer: { | ||
| // https: { | ||
| // key: './certificates/localhost-key.pem', |
There was a problem hiding this comment.
✍️
ローカルで HTTPS の下より確認できるようにしています
オレオレ証明書 (.pem) の作成については、各自進めていただければと思います
|
みれました |
toshick
reviewed
May 15, 2024
| } | ||
|
|
||
| if (!supabaseUrl || !supabaseKey) { | ||
| return { signedUserId: null, onAuthChanged } |
There was a problem hiding this comment.
最後のreturnにあわせて
return { hasAuth: false, onAuthChanged }
にするか、
return { signedUserId: null, hasAuth: false, onAuthChanged }
がよいかと思いました。
今のところ signedUserId を使わないのであれば返却しなくてもよいかもしれないです。
２つのreturnの中身を統一すべきかと思います
There was a problem hiding this comment.
ご確認いただきありがとうございます！
おっしゃるように signedUserId は使用されていませんので、削除しておきました mm
Deploying vuefes-2024-designsystem with
|
| Latest commit: |
735350d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09d143a3.vuefes-2024-designsystem.pages.dev |
| Branch Preview URL: | https://feature-invite-user-admin-se.vuefes-2024-designsystem.pages.dev |
|
一旦マージします、何かあれば随時 PR 上げてください mm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと一覧
cc: @vuejs-jp/vuefes-2024-maintainer