Skip to content

fix(compiler-core): fix resolveSetupReference #11438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(compiler-core): fix resolveSetupReference #11438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fca974
fix(compiler-core): fix resolveSetupReference
linzhe141 Jul 26, 2024
a92fbdb
chore: update test
linzhe141 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/compiler-core/__tests__/transforms/transformElement.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,4 +1381,14 @@ describe('compiler: element transform', () => {
],
})
})

test('resolveSetupReference handle `kebab-case` component', () => {
const { node } = parseWithElementTransform(`<view-component/>`, {
isNativeTag: () => false,
bindingMetadata: {
ViewComponent: BindingTypes.SETUP_CONST,
},
})
expect(node.tag).toBe(`$setup["ViewComponent"]`)
})
})
6 changes: 3 additions & 3 deletions packages/compiler-core/src/transforms/transformElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,12 +331,12 @@ function resolveSetupReference(name: string, context: TransformContext) {
if (bindings[name] === type) {
return name
}
if (bindings[camelName] === type) {
return camelName
}
if (bindings[PascalName] === type) {
return PascalName
}
if (bindings[camelName] === type) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right fix.
consider:

import viewComponent from '/src/components/ViewComponent.vue' // v is lowercase
async function ViewComponent(index) { // V is uppercase

}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, I will try to modify it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But after thinking about it, I still think that such a tag should match PascalName, and the editor seems to match it in this way.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PascalName is recommended in the document, but this actual a breaking change.

return camelName
}
}

const fromConst =
Expand Down