Skip to content

Conversation

@edison1105
Copy link
Member

@edison1105 edison1105 commented Apr 18, 2025

// <template>
//   <button @click="show=!show"> toggle </button>
//   <div>
//     <Comp v-if="show"/>
//   </div>
// </template>

function render(_ctx, $props, $emit, $attrs, $slots) {
  const n0 = t0()
  const n4 = t1()
  _setInsertionState(n4)
  const n1 = _createIf(() => (_ctx.show), () => {
    const n3 = _createComponent(_ctx.Comp)
    return n3
  })
  n0.$evtclick = () => (_ctx.show=!_ctx.show)
  return [n0, n4]
}

The block of n3 will be inserted twice due to the following code in both apiCreateIf.ts and component.ts

if (!isHydrating && _insertionParent) {
  insert(xxx, _insertionParent, _insertionAnchor)
}

@edison1105 edison1105 changed the title fix(runtime-vapor): reset insertion state to avoid duplicate block inserts fix(runtime-vapor): reset insertion state to avoid duplicate block inserts during non-hydration Apr 18, 2025
@netlify
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 34e8268
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/68520f5becc79e00088a8955
😎 Deploy Preview https://deploy-preview-13220--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 18, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13220

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13220

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13220

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13220

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13220

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13220

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13220

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13220

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13220

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13220

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13220

vue

npm i https://pkg.pr.new/vue@13220

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13220

commit: 34e8268

@edison1105 edison1105 added the scope: vapor related to vapor mode label Apr 18, 2025
@edison1105 edison1105 added ready to merge The PR is ready to be merged. labels Jun 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jun 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@edison1105 edison1105 merged commit 99a8c6d into vapor Jun 18, 2025
16 checks passed
@edison1105 edison1105 deleted the edison/fix/resetInsertion branch June 18, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge The PR is ready to be merged. scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants