Skip to content

fix(compiler-vapor): handle special characters in cached variable names #13626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,21 @@ export function render(_ctx) {
}"
`;

exports[`v-on > component event with special characters 1`] = `
"import { resolveComponent as _resolveComponent, createComponentWithFallback as _createComponentWithFallback } from 'vue';

export function render(_ctx) {
const _component_Foo = _resolveComponent("Foo")
const _on_update_model = () => {}
const _on_update_model1 = () => {}
const n0 = _createComponentWithFallback(_component_Foo, {
"onUpdate:model": () => _on_update_model,
"onUpdate-model": () => _on_update_model1
}, null, true)
return n0
}"
`;

exports[`v-on > dynamic arg 1`] = `
"import { on as _on, renderEffect as _renderEffect, template as _template } from 'vue';
const t0 = _template("<div></div>", true)
Expand Down
12 changes: 12 additions & 0 deletions packages/compiler-vapor/__tests__/transforms/vOn.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -695,4 +695,16 @@ describe('v-on', () => {
expect(code).matchSnapshot()
expect(code).include('n0.$evtclick = e => _ctx.handleClick(e)')
})

test('component event with special characters', () => {
const { code } = compileWithVOn(
`<Foo @update:model="() => {}" @update-model="() => {}" />`,
)

expect(code).matchSnapshot()
expect(code).contains('const _on_update_model = () => {}')
expect(code).contains('const _on_update_model1 = () => {}')
expect(code).contains('"onUpdate:model": () => _on_update_model')
expect(code).contains('"onUpdate-model": () => _on_update_model1')
})
})
3 changes: 2 additions & 1 deletion packages/compiler-vapor/src/generators/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
genCall,
genMulti,
} from './utils'
import { genExpression } from './expression'
import { genExpression, genVarName } from './expression'
import { genPropKey, genPropValue } from './prop'
import {
type SimpleExpressionNode,
Expand Down Expand Up @@ -102,6 +102,7 @@ export function genCreateComponent(

function getUniqueHandlerName(context: CodegenContext, name: string): string {
const { seenInlineHandlerNames } = context
name = genVarName(name)
const count = seenInlineHandlerNames[name] || 0
seenInlineHandlerNames[name] = count + 1
return count === 0 ? name : `${name}${count}`
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler-vapor/src/generators/expression.ts
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ function parseExp(context: CodegenContext, content: string): Node {
return parseExpression(`(${content})`, options)
}

function genVarName(exp: string): string {
export function genVarName(exp: string): string {
return `${exp
.replace(/[^a-zA-Z0-9]/g, '_')
.replace(/_+/g, '_')
Expand Down