Skip to content

fix(v-model): number modifier should update input value #13959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+12 −10
Open

fix(v-model): number modifier should update input value #13959

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
563840c
fix(v-model): number modifier should update input value
cszhjh Oct 2, 2025
ae42f08
test: update
cszhjh Oct 2, 2025
551f366
Merge branch 'main' into fix/number-modifier
cszhjh Oct 4, 2025
825676a
Merge branch 'main' into fix/number-modifier
cszhjh Oct 9, 2025
7c88b2e
chore(v-model): refactor value casting logic into a separate function
edison1105 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/runtime-dom/__tests__/directives/vModel.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,9 @@ describe('vModel', () => {
triggerEvent('input', number)
await nextTick()
expect(data.number).toEqual(1.2)
triggerEvent('change', number)
await nextTick()
expect(number.value).toEqual('1.2')

trim.value = ' hello, world '
triggerEvent('input', trim)
Expand Down
11 changes: 9 additions & 2 deletions packages/runtime-dom/src/directives/vModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,16 @@ export const vModelText: ModelDirective<
}
el[assignKey](domValue)
})
if (trim) {
if (trim || castToNumber) {
addEventListener(el, 'change', () => {
el.value = el.value.trim()
let newValue = el.value
if (trim) {
newValue = newValue.trim()
}
if (castToNumber) {
newValue = looseToNumber(newValue)
}
el.value = newValue
})
}
if (!lazy) {
Expand Down
Loading