fix(runtime-vapor): Loss of css var in Teleport

[jackma9604]

Playground

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
compiler-dom.global.prod.js	85.5 kB	30 kB	26.5 kB
runtime-dom.global.prod.js	108 kB	40.7 kB	36.6 kB
vue.global.prod.js	167 kB	60.8 kB	54 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	48.3 kB	18.9 kB	17.3 kB
createApp	57.3 kB	22 kB	20.1 kB
createApp + vaporInteropPlugin	85.4 kB	31.9 kB	28.8 kB
createVaporApp	27.6 kB	10.6 kB	9.72 kB
createSSRApp	61.6 kB	23.9 kB	21.7 kB
defineCustomElement	63.3 kB	23.9 kB	21.8 kB
overall	72.1 kB	27.3 kB	24.9 kB

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14284

npm i https://pkg.pr.new/@vue/compiler-core@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14284

npm i https://pkg.pr.new/@vue/compiler-dom@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14284

npm i https://pkg.pr.new/@vue/compiler-sfc@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14284

npm i https://pkg.pr.new/@vue/compiler-ssr@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14284

npm i https://pkg.pr.new/@vue/compiler-vapor@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14284

npm i https://pkg.pr.new/@vue/reactivity@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14284

npm i https://pkg.pr.new/@vue/runtime-core@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14284

npm i https://pkg.pr.new/@vue/runtime-dom@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14284

npm i https://pkg.pr.new/@vue/runtime-vapor@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14284

npm i https://pkg.pr.new/@vue/server-renderer@14284

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14284

npm i https://pkg.pr.new/@vue/shared@14284

yarn add https://pkg.pr.new/@vue/[email protected]

vue

pnpm add https://pkg.pr.new/vue@14284

npm i https://pkg.pr.new/vue@14284

yarn add https://pkg.pr.new/[email protected]

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14284

npm i https://pkg.pr.new/@vue/compat@14284

yarn add https://pkg.pr.new/@vue/[email protected]

commit: d6b496c

[jackma9604]

the vdom mode has the same problem. I'm trying to fix it!

[edison1105]

Thanks for the PR!
Could you please add a test case?

[edison1105]

should consider recursively processing child nodes
see repl with this PR

[jackma9604]

Okay, I'll revise it!

[edison1105]

Thanks for the PR. I've made minor tweaks. see d6b496c

• move test to useCssVars.spec.ts
• avoid register updateCssVars callback to instance's updated hooks because the DOM tree won't
  changed when the component updated.