Skip to content

fix(runtime-core): should not fallthrough attr if it has been declared as a prop in the root component #8976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(runtime-core): should not fallthrough attr if it has been declared as a prop in the root component #8976

wants to merge 6 commits into from
+61 −3

Conversation

gucovip
Copy link
Contributor

@gucovip gucovip commented Aug 15, 2023 •
edited
Loading

close #9039
NOTE: this maybe a breaking change

@gucovip gucovip changed the title fix(runtime-core): should not fallthrough attrs if attr declared in r… fix(runtime-core): should not fallthrough attrs if attr declared in root component as prop Aug 15, 2023
@gucovip gucovip changed the title fix(runtime-core): should not fallthrough attrs if attr declared in root component as prop fix(runtime-core): should not fallthrough attr if it has been declared as a prop in the root component Aug 15, 2023
@sxzz

This comment was marked as outdated.

Sign in to view
@vue-bot

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86 kB (+139 B) 32.7 kB (+59 B) 29.5 kB (+45 B)
vue.global.prod.js 132 kB (+139 B) 49.4 kB (+53 B) 44.3 kB (+35 B)

Usages

Name Size Gzip Brotli
createApp 48 kB (+139 B) 18.9 kB (+46 B) 17.2 kB (+39 B)
createSSRApp 50.8 kB (+139 B) 20 kB (+48 B) 18.2 kB (+43 B)
defineCustomElement 50.4 kB (+139 B) 19.7 kB (+44 B) 18 kB (+53 B)
overall 61.4 kB (+139 B) 23.7 kB (+50 B) 21.6 kB (+38 B)

@sxzz
Copy link
Member

sxzz commented Aug 24, 2023

Sry, but I didn't get your point. Could you please provide more detailed info about your PR, like motivation? Also, unit tests are required.

@edison1105
Copy link
Member

edison1105 commented Aug 25, 2023 •
edited
Loading

@sxzz
this PR seems to fix this scenario and not related to #8969

EDIT:
close #9039

@sxzz
Copy link
Member

sxzz commented Sep 1, 2023

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 1, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
nuxt ✅ success
pinia ✅ success
quasar ✅ success
router ✅ success
test-utils ✅ success
vant ❌ failure
vite-plugin-vue ✅ success
vitepress ✅ success
vue-i18n ✅ success
vue-macros ❌ failure
vuetify ✅ success
vueuse ✅ success
vue-simple-compiler ✅ success

@sxzz
Copy link
Member

sxzz commented Sep 1, 2023

See #9039 (comment)

This was referenced Nov 19, 2024
Closed
Closed
@edison1105 edison1105 mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change need discussion

Projects

Issue / PR Management
Status: Breaking
Triage Session
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The attr fall-through overrides the value of prop

4 participants

@gucovip @sxzz @vue-bot @edison1105