chore(vite): remove newline on server urls #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferferga
changed the title
✅ Deploy Preview for vue-devtools-docs canceled.
|
webfansplz
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on unocss/unocss#4361 (which takes great inspiration from Vue Devtools, thanks!), I noticed that there is a newline character that introduces trailing between the console output of any other Vite plugin. We seem to assume that Vue Devtools is the only plugin that will print to the console, however that might not always be true (as seen in the linked's PR screenshot).
Though the issue this PR is tackling is a nitpick, I believe it's better to no show any space at all between the help commands rather than force all plugins to have
enforce: 'pre'or mess up with the "styling" of the console output.