Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixes in 3.5 updates on reactivity-api page #3016

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

AloisSeckar
Copy link
Contributor

@AloisSeckar AloisSeckar commented Sep 13, 2024

Description of Problem

  1. In 66a8ced example for "side effect cleanup" got duplicated for watchEffect (lines 281 and 318)
  2. The example for "Pausing / resuming the watcher" shows watchEffect instead of watch

Proposed Solution

  1. Remove the duplicated text
  2. Fix the function name

Additional Information

  1. I removed the original occurence to maintain same order of examples as for watch function listed later on the page

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit c414bd2
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/66e479e73c7f410008366dcd
😎 Deploy Preview https://deploy-preview-3016--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AloisSeckar AloisSeckar changed the title docs: remove duplicated example for watchEffect docs: fixes in 3.5 updates on reactivity-api page Sep 13, 2024
@yyx990803 yyx990803 merged commit 27dd985 into vuejs:main Sep 16, 2024
5 checks passed
@AloisSeckar AloisSeckar deleted the reactivity-core branch September 17, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants