feat: warn when create store with exsist id #1564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinia-official canceled.
|
|
@posva, hi, it's ok? |
OXXXRA
changed the title
|
Thanks but this seem like a copy of #1452 with only one test added... That PR implementation doesn't work, if you try it locally you will see how the console is flushed with warnings when running the tests... Also, the warning is still not dev only. |
|
@posva, now i added output only for dev, also checked warn output in playground. |
seanohue
reviewed
Oct 3, 2022
seanohue
reviewed
Oct 3, 2022
|
Thanks but this still doesn't work and my feedback is getting ignored so I prefer closing this so other contributors feel free to open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1394