refactor/use shiki's transformerMetaHighlight() and add support for multi-key meta notation like add={1} remove={2}
#4718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… like `add={1} remove={2}`
…gName being `js{1}`
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
c5a8428 to
8abbe29
Compare
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
084cf43 to
d3a1567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
transformerMetaHighlight()Use shiki's transformer to do meta highlight.
Support for multi-key line numbers notation in meta
Modified
highlightLinePlugin()to support multi-key meta notation likeadd={1} remove={2}.In details,
markdown-it-attrsplugin will parse and remove the last{0}notation in meta string, e.g.js add={1} remove={2}=>js add={1} remove=. The original handling add the line numbers back to token but without braces{}, causingtransformerMetaHighlight()unable to match the notations. So the braces is added in this PR. Also make sure there is a space between language name and{0}notations.Linked Issues
#4704