Skip to content

fix: changed a type for AsyncComponentFactory component(fix #10252) #10253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: changed a type for AsyncComponentFactory component(fix #10252) #10253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f75a39d
fix: fixed a type for AsyncComponentFactory component
NataliaTepluhina Jul 10, 2019
3be9e28
fix: add test for AsyncComponentFactory
NataliaTepluhina Jul 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/options.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export type AsyncComponentPromise<Data=DefaultData<never>, Methods=DefaultMethod
) => Promise<Component | EsModuleComponent> | void;

export type AsyncComponentFactory<Data=DefaultData<never>, Methods=DefaultMethods<never>, Computed=DefaultComputed, Props=DefaultProps> = () => {
component: AsyncComponentPromise<Data, Methods, Computed, Props>;
component: Promise<Component | EsModuleComponent>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @pikax noted, Data, Methods,... are not used anymore. Maybe we should pass them to Component

loading?: Component | EsModuleComponent;
error?: Component | EsModuleComponent;
delay?: number;
Expand Down
8 changes: 8 additions & 0 deletions types/test/options-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,5 +477,13 @@ Vue.component('functional-component-v-model', {
}
});

Vue.component('async-component-factory', () => ({
component: import('./es-module'),
loading: Vue.component(''),
error: Vue.component(''),
delay: 100,
timeout: 200
}))


Vue.component('async-es-module-component', () => import('./es-module'))