feat(plugin-markdown-chart)!: avoid potential XSS attack #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: echart variables in scripts are changed, script blocks MUST be manually allowed
Member
Author
|
@pengzhanbo RFC here, I believe this is a necessary change, as most maintainers may not realize that certain JS code blocks from chart containers will be executed in browser, especially these functions are default enabled via certain templates. We add 2 UPPER_CASE options for this and ensure only scripts from a whitelist can be run in site. |
Copilot finished reviewing on behalf of
Mister-Hope
November 24, 2025 08:35
Pull Request Test Coverage Report for Build 19629147442Details
💛 - Coveralls |
Mister-Hope
changed the title
Mister-Hope
changed the title
pengzhanbo
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES: echart variables in scripts are changed, script blocks MUST be manually allowed