-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VDataTable): highlight filter matches #21073
base: dev
Are you sure you want to change the base?
Conversation
Matches are keyed on item.value so it does funny things if item-value is not set correctly like highlight the second character of every item.
|
@@ -164,3 +164,6 @@ | |||
|
|||
&-active | |||
color: $data-table-header-mobile-chip-icon-color-active | |||
|
|||
.v-data-table__mask | |||
background: rgb(var(--v-theme-on-surface-variant)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is bg-primary
class without additional theme="dark"
a valid use case for v-data-table
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it fixes it but I hate that fix. Mainly because when we say theme="dark", we're saying use those colors. So now everything inside of that component would operate with a different palette.
Description
Closes #20357
Depends on #16462
Markup: