T7621 vyos_firewall_global features

[omnom62]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

https://vyos.dev/T7621

Related PR(s)

Component(s) name

vyos_firewall_global

Proposed changes

How to test

Test results

• Sanity tests passed
• Unit tests passed

Tested against VyOS versions:

• 1.3.8
• 1.4-rolling-202201010100
• 1.5-stream-2025-Q1

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the ansible sanity and unit tests
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added unit tests to cover my changes
• I have added a file to changelogs/fragments to describe the changes

[gaige]

@omnom62 I'm comfortable with your current code. I'm adding the regex options here if you want to look at them. Honestly, they're harder to read than your straight-up checks and there may not be a real benefit to them unless we see a lot of variability.

You might want to make a note on which version has the missing space and the missing quotes, just so we know when we can remove them.

[evgmol-wbio]

@omnom62 I'm comfortable with your current code. I'm adding the regex options here if you want to look at them. Honestly, they're harder to read than your straight-up checks and there may not be a real benefit to them unless we see a lot of variability.

You might want to make a note on which version has the missing space and the missing quotes, just so we know when we can remove them.

@gaige I have this comment - where will I put the note to:
`
Diff output differs between 1.3.x and 1.4+ version:

• quote marks - e.g. 1.3.8 does not use them, 1.4+ does.
• 1.3.8 does not have space between +/- sign here +network 1.1.1.1/32`