Update to Minecraft 1.21+ and better build process #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytdev
requested changes
Feb 26, 2025
There was a problem hiding this comment.
i really appreciate the effort you've put into the pr. however, i'd like to keep things simple as i could, especially for a small project like this. by simple, i mean avoiding bloatware and the fancy tools.
it's brilliant that you've considered adding those tools and improving the build system to automate some tasks, but i think it's a bit too much for a project of this scale.
really appreciate the effort mate!!~
:]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the addon dependencies to Minecraft 1.21+.
Rework the addon build process to match Mojang standard.
Fix some issues with error management of scripts.