Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the distinction between local and fully qualified IDs. #442

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

jrhender
Copy link
Contributor

@jrhender jrhender commented Jan 27, 2025

Addresses #425 . This is currently only relevant to the workflows and exchanges APIs so it is added to that section.


Preview | Diff

@jrhender jrhender requested review from TallTed, dlongley, msporny and mkhraisha and removed request for msporny, mavarley and mkhraisha January 27, 2025 23:03
This is currently only relevant to the workflows and exchanges APIs
so it is added to that section.
@jrhender jrhender force-pushed the jrhender-425-local-id-clarification branch from fdf8d87 to ec1a66c Compare January 27, 2025 23:08
Copy link
Collaborator

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comma

index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@jrhender jrhender requested a review from TallTed January 28, 2025 19:41
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit. Thanks!

index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presuming application of @dlongley's suggestion

index.html Outdated Show resolved Hide resolved
@msporny msporny merged commit 65c2d84 into main Feb 4, 2025
1 check passed
@msporny msporny deleted the jrhender-425-local-id-clarification branch February 4, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants