Specify account labels #669
Conversation
|
Discussed on https://github.com/fedidcg/meetings/blob/main/2024/2024-11-26-notes.md. Needs further review. |
|
I would like to reiterate why we think this proposal is better than expanding login_hint/domain_hint to cover this. Conceptually, we envision this as an IDP-internal selector that the RP need not/should not be aware of. Hence the design of putting it in the config URL to filter accounts from the account endpoint, both of which are under control of the IDP. Putting this under control of the RP makes it easy to make programming errors -- forgetting to specify an account label leads to a UI with accounts that will not work, which is not a great user experience. Keeping this under control of the config file avoids that. I realize that I did not do a good job framing this well in the meeting, sorry about that. I hope this helps in addition to the "alternatives considered" in #553. |
|
Discussed again on 11 February 2025 call. Discussion: Agree in principle, may need a bit of bikeshedding. |
|
On behalf of Chrome, we are happy to rename this. Straw proposal:
Open to other suggestions! |
|
I have updated the PR with the new names. I believe this is ready to merge now, unless @bvandersloot-mozilla wants to take another look? |
SHA: e3e894c Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: e3e894c Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Discussed in 11 March meeting. |
Allows "supports_use_other_account" in the toplevel of the
config file.
Also renames "labels" in the account endpoint to "label_hints"
and flattens "accounts: { include: "foo" }" to just
a toplevel "account_label".
All changes behind the new "FedCmOtherAccountAndLabelsNewSyntax"
flag. Even with the flag enabled, the old syntax is still
accepted for now.
As per the discussions here:
w3c-fedid/FedCM#669
w3c-fedid/FedCM#678
Bug: 404568028
Change-Id: Iba33c5f546c68f35ca2a1228096a7a31a68767a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6370034
Reviewed-by: Nicolás Peña <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1435018}
Bug: #553
Preview | Diff