Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user agent to wait or reject the request before any fetch #676

Merged
merged 9 commits into from
Feb 14, 2025
Merged

Allow user agent to wait or reject the request before any fetch #676

merged 9 commits into from
Feb 14, 2025

Conversation

npm1
Copy link
Collaborator

@npm1 npm1 commented Nov 1, 2024 •
edited by pr-preview bot
Loading

See #675

Preview | Diff

@npm1 npm1 requested a review from samuelgoto November 1, 2024 20:41
@cbiesinger
Copy link
Collaborator

isn't this redundant with https://w3c-fedid.github.io/FedCM/#create-identity-credential:~:text=The%20user%20agent%20can%20decide%20when%20to%20continue%20with%20the%20next%20steps. ?

@npm1
Copy link
Collaborator Author

npm1 commented Nov 1, 2024

isn't this redundant with https://w3c-fedid.github.io/FedCM/#create-identity-credential:~:text=The%20user%20agent%20can%20decide%20when%20to%20continue%20with%20the%20next%20steps. ?

Yea I was just updating since I saw that. Unfortunately that is not good enough since it does not allow rejecting, so moved it to right at the beginning of the create algorithm.

@npm1 npm1 changed the title Allow user agent to show a dialog before accounts fetch Allow user agent to wait or reject the request before any fetch Nov 1, 2024
cbiesinger
cbiesinger approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@cbiesinger cbiesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good.

TallTed
TallTed reviewed Nov 4, 2024
View reviewed changes
TallTed
TallTed reviewed Nov 4, 2024
View reviewed changes
@npm1 @TallTed
Update spec/index.bs
82a3863 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@npm1 npm1 added the agenda+ Regular CG meeting agenda items label Jan 31, 2025
@yi-gu yi-gu removed the agenda+ Regular CG meeting agenda items label Feb 12, 2025
@npm1 npm1 requested review from bvandersloot-mozilla and removed request for samuelgoto February 12, 2025 21:49
@npm1 npm1 merged commit aa3ea63 into main Feb 14, 2025
2 checks passed
@npm1 npm1 deleted the optionalDialog branch February 14, 2025 18:23
github-actions bot added a commit that referenced this pull request Feb 14, 2025
@npm1 @github-actions
Allow user agent to wait or reject the request before any fetch (#676)
4ffcf25 
SHA: aa3ea63
Reason: push, by npm1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@cbiesinger cbiesinger cbiesinger approved these changes

@bvandersloot-mozilla bvandersloot-mozilla bvandersloot-mozilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@npm1 @cbiesinger @TallTed @bvandersloot-mozilla @yi-gu