-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single-get multi IDP support for passive mode #686
base: main
Are you sure you want to change the base?
Conversation
ptal |
Discussed at Jan 21, 2025 meeting minutes. |
This overall seems reasonable, but raises questions for me about how a browser with an IDP picker integrates with the spec. Right now it works with single IDP, however, I think that I want to be able to show account information in the IDP picker where there is already a linkage. How does this handle where a response is in the connected account set? Does it still show the dialog? |
Hey Ben, sorry not sure I follow your questions but trying to answer:
Regarding IDP picker with account information: sure, this is intended to be allowed. You can show any UI before fetching the accounts, so in particular you can show UI using some information that you cache from an account in the connected accounts set. However, I do worry that this effectively removes auto reauthentication since you can only really know the returning accounts after fetching. You could guess when it may happen based on the connected accounts set but that seems brittle.
Not sure I follow. If there are accounts in the connected account set, this just means it may be possible to perform auto reauthentication. Of course, the user agent is encouraged to nudge the user towards these accounts as well as accounts whose |
@bvandersloot-mozilla is your question maybe this: does the algorithm allow fetching and displaying accounts only from IDPs who have accounts in the connected set, and only showing the IDP name for the other IDPs (fetching accounts once you click that)? |
@cbiesinger, that is precisely what I meant, thanks! |
Added support for this (during the wait, the user agent may set the provider list to a subset of itself) |
Ping @bvandersloot-mozilla. Let me know if you want me to add active mode support here as well or any other comments so I can merge this |
Adds support for multiple IDPs on passive mode by:
configURL
toIdentityCredential
so the RP knows which IDP the credential corresponds to.Also some unrelated errors noticed while drafting this PR are fixed.
Relevant issue: w3c-fedid/multi-idp#2
Preview | Diff