-
Notifications
You must be signed in to change notification settings - Fork 410
Infrastructure: Support rate-limit retries in link-checker #3273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For reviewers: this has now been re-ran 5 times without any unexpected failures to the link-checker build |
scripts/link-checker.js
Outdated
// Found the retry-after unit returned from response headers too | ||
// variable to use here, but ~15 seconds seems like a safe | ||
// default | ||
const retryAfter = baseDelay * 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the formula for the delay in this case need to be different than the formula for the delay in case of an exception? If not, then we could reduce duplication by simply throwing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, de-duped and also removed left-over retry logic in e08b32c
Looking good, @howard-e! I'd love to merge this for you, but GitHub feels differently:
|
Thanks! (and thinking we should look into your permissions here) |
From #3264 (comment):
Originally posted by @howard-e in #3264 (comment)
Looking again at the responses, the response codes were 429 and an outlier 508 (which was still most likely related to rate limiting).
About this PR:
Since calls to external links are coming from an unauthenticated source, unable to parse out any reliable retry-related headers from the responses and even if, the links in this project are variable enough that, that may prove difficult to normalise. So defaulting to 15 seconds.
Note: Harder to confirm this on my local setup (but possible). Leaving as a draft while I confirm using this PR.WAI Preview Link (Last built on Wed, 21 May 2025 22:13:40 GMT).