-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-overflow-5] Define scroll-markers #10243
Conversation
…attribute and associated behaviors.
I'm sure there's a lot of important details missing here, but it might be useful to have something written down to point to and work out the details over PRs and issues. WDYT? |
Co-authored-by: Tab Atkins Jr. <[email protected]>
Co-authored-by: Tab Atkins Jr. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @tabatkins!
Co-authored-by: Tab Atkins Jr. <[email protected]>
I agree, but the plan was to put it into Overflow L5 along with the current fragmentation appendix, not to patch Overflow L4. :) #9745 (comment) Wrt the content of this, I think it needs more explanation of the use cases it's trying to solve (and the use case it's not trying to solve). For my part, I don't understand why we aren't trying to solve the "highlight the relevant table of contents entry" item along with this, for example. The part about only the currently-active scroll marker being focusable is also weird. How do you activate a scroll marker control with the keyboard if it's not focusable? |
::scroll-marker-group pseudo element acts as an area to which ::scroll-marker pseudo elements are flowed. It is a container for `navigation dots` of carousel (e.g. dots for choosing image in gallery). ::scroll-marker-group is the first/last child of the originating element, depending on the scroll-marker property (after/before/none). Note: if there is ::view-transition pseudo on the originating element, it would be the last child instead. Note: this CL places box of ::scroll-marker-group as a child of originating element instead of prev/next sibling of it for now. This will be fixed in following CLs. No AX actions are needed, since ::scroll-marker-group acts as a container for ::scroll-marker pseudo elements. AX tests will be added with ::scroll-marker CL. Spec PR: w3c/csswg-drafts#10243 Bug: 332396355 Change-Id: I269c92f9dfe2d13c9595991ee371355f0046bf8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545381 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1306382}
Sorry about that, this was me misreading the resolution notes. I've created css-overflow-5, moving the fragmentation appendix as we agreed, and moved this over there.
We are. The
The current algorithm will always produce a selected marker: https://github.com/w3c/csswg-drafts/pull/10243/files#diff-fdbff78a41c06b32b51fc29f900df82da5efa11aa9e2e3394047d39c889569f9R932 I agree if there were not an active marker we'd want to do something similar to a radio group where the first one can get focused. |
Merging and moving discussion to followup issues per discussion with @fantasai. |
Defines scroll-markers properties, pseudo-elements, scrolltarget attribute and associated behaviors for #9745.